Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages when memory is exhausted while sorting #4348

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Improve error messages when memory is exhausted while sorting #4348

merged 1 commit into from
Nov 25, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 23, 2022

Which issue does this PR close?

Follow on to #4330

Rationale for this change

The idea is to make it clearer what is going on to a user who sees this error message

What changes are included in this PR?

Implement suggestions from #4330 (comment)

Are these changes tested?

Yes

Are there any user-facing changes?

better error messages

@alamb alamb mentioned this pull request Nov 23, 2022
Merged
@github-actions github-actions bot added the core Core DataFusion crate label Nov 23, 2022
tustvold
tustvold approved these changes Nov 24, 2022
View reviewed changes
datafusion/core/src/execution/disk_manager.rs
///
/// If the file can not be created for some reason, returns an
/// error message referencing the request description
pub fn create_tmp_file(&self, request_description: &str) -> Result<NamedTempFile> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully once we rework the error handling story, we can move away from this nonsense

@alamb alamb merged commit 0d65394 into apache:master Nov 25, 2022
@ursabot
Copy link

ursabot commented Nov 25, 2022

Benchmark runs are scheduled for baseline = e34c6c3 and contender = 0d65394. 0d65394 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb deleted the alamb/better_error_disk_manager branch August 8, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alamb @ursabot @tustvold